8000 Menu refactor by codebytere · Pull Request #10888 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Menu refactor #10888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Oct 26, 2017
Merged

Menu refactor #10888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
b7ebee9
refactor indexOfItemById
codebytere Oct 23, 2017
1cd5376
clean up indexToInsertByPosition
codebytere Oct 23, 2017
f9c3123
clean up menuWillShow
codebytere Oct 23, 2017
61a93c7
clean up popup
codebytere Oct 23, 2017
87802b2
initial port of things into a Menu class
codebytere Oct 23, 2017
577c004
update to ES6
codebytere Oct 23, 2017
3fc5d51
clean up delegate
codebytere Oct 23, 2017
9038987
significant cleanup; all tests still passing
codebytere Oct 24, 2017
9b364d5
refactor menuWillShow
codebytere Oct 24, 2017
508b614
remove excess code in delegate
codebytere Oct 24, 2017
7c0f732
appease the linter overlords
codebytere Oct 24, 2017
b1e707d
abstract out switch case from Menu.prototype.insert
codebytere Oct 24, 2017
f93121b
don't reassign parameters in Menu.prototype.popup
codebytere Oct 24, 2017
75f32af
clean up excess code from generateGroupId
codebytere Oct 24, 2017
e893523
clean falsy statements
codebytere Oct 24, 2017
0e6100a
upgrade menu spec to ES6
codebytere Oct 25, 2017
d54148d
remove from spec
codebytere Oct 25, 2017
f7bc548
add a few more tests to api_menu_spec
codebytere Oct 25, 2017
1354543
remove .only from spec
codebyt 8000 ere Oct 25, 2017
ffd43c1
remove quotes and const replaces
codebytere Oct 25, 2017
bccaf56
remove common sense comments
codebytere Oct 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
0