Remove asar: protocol, use file: protocol instead #1077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IMO it's actually a lot nicer to not have a separate protocol for it. |
zcbenz
added a commit
that referenced
this pull request
Feb 1, 2015
Remove asar: protocol, use file: protocol instead
This was referenced Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
asar:protocol, and makefile:protocol compatible withasararchives instead.For custom protocols there are some limitations in Chrome. One limitation is the custom protocol has to be a standard protocol to be able to make HTML document fully featured(#1071), but for standard protocol URLs like
asar://C:/fileare invalid. For Chrome thefile:is hard-coded on may places to make it a standard protocol while keeping the ability to represent Windows file paths.Another limitation is there are some security restrictions for custom protocol (#1069), which are unnecessary if the custom protocol already accesses the file system. The
file:bypasses those security restrictions also by hard-coding the conditions in code.So it is nearly impossible to make
asar:protocol work exactly likefile:protocol, in order to fix this, we have to avoid using a new protocol and makefile:protocol supportasararchives.Fixes #1071.
Fixes #1069.