Added the prune of docker images when uninstall #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
flobernd
approved these changes
Jun 6, 2025
start-local.sh
Outdated
|
|
||
| cat >> uninstall.sh <<- EOM | ||
| if ask_confirmation; then | ||
| docker rmi docker.elastic.co/elasticsearch/elasticsearch:${es_version} |
There was a problem hiding this comment.
Just some thoughts regarding a potential unhappy path: If the user has any other container that still actively uses the image, this command will fail.
I can imagine different strategies:
- This should be a rare case, let's not do anything. The user might have to prune the image manually for the
kibanaimage, since the script will exit early at this point. - Change to
docker rmi ... || trueto allow the script to continue and try to at least prune thekibanaimage (if that's not in use as well). - Proactively check, if the image is still in use before attempting to remove it (e.g.
if [ -n "$(docker ps -a --filter ancestor=docker.elastic.co/elasticsearch/elasticsearch:${es_version} --format '{{.ID}}')" ]; then)
Personally I would go with the 2. approach since this one:
- Makes the best possible effort to remove all images, even if the removal of one image fails
- It's simple
- No additional custom logic in
start-local.sh - Standard Docker error message on failure
- No additional custom logic in
There was a problem hiding this comment.
I think 2 or 3 are valid options. Let me try with 3, I like the idea of checking before and if the image is already in use in other services I can even skip the question.
|
@flobernd I actually proposed a different approach. I check the execution of each if docker rmi "docker.elastic.co/elastic...:${es_version}" >/dev/null 2>&1; then
echo "Image docker.elastic.co/elastic...:${es_version} removed successfully"
else
echo "Failed to remove image docker.elastic.co/elastic...:${es_version}. It might be in use."
fiIn this way I don't need to change the execution flow and I manage all the use cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the #56 proposal. It adds this questions when running
uninstall.shscript:If confirm is
yesthe script execute the following commands:The docker disk images of Elasticsearch and Kibana 9.0.2 is about 2.6 GB.