8000 Update mergify with new 9.1 branch by donoghuc · Pull Request #17740 · elastic/logstash · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update mergify with new 9.1 branch #17740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

donoghuc
Copy link
Member

Update mergify data to add the newly created 9.1 branch

Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor
mergify bot commented Jun 25, 2025

This pull request does not have a backport label. Could you fix it @donoghuc? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • If no backport is necessary, please add the backport-skip label

@@ -130,3 +130,18 @@ pull_request_rules:
labels:
- "backport"
title: "[{{ destination_branch }}] {{ title }} (backport #{{ number }})"

- name: backport patches to 9.1 branch
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codereview: Why does the 8.19 section look different than the other?

Copy link
Member
@robbavey robbavey Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the template was simplified by @v1v when 8.19 support was added, https://github.com/elastic/logstash/pull/17567/files

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#17551 introduced the defaults, so those specific config entries per backport pull_request rule is not needed anymore.

8000 Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#17742 is the one removing those duplicated entries

@donoghuc donoghuc added the backport-skip Skip automated backport with mergify label Jun 25, 2025
@v1v
Copy link
Member
v1v commented Jun 26, 2025

I recall, I enabled some automation when a new minor was created at https://github.com/elastic/logstash/pull/16937/files#diff-9c6b820333e02ae31783c38a5a6b83e6adb6bfcdaaee16b451090b8cedf618a9R63

However, I think https://github.com/elastic/logstash/actions/runs/15888662997/job/44806654871#step:13:1 failed as it used 8.19. I wonder If using 9.1 likely this PR should have been created?

@donoghuc
Copy link
Member Author

However, I think https://github.com/elastic/logstash/actions/runs/15888662997/job/44806654871#step:13:1 failed as it used 8.19. I wonder If using 9.1 likely this PR should have been created?

Ah, i actually didnt run that job for 9.1. I (I updated the lock file directly). Good to know that is part of that workflow. I'll just do this one manualy.

@donoghuc donoghuc force-pushed the mergify-9.1-branch branch from 6a696b6 to 04ea91a Compare June 26, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0