-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Update mergify with new 9.1 branch #17740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
This pull request does not have a backport label. Could you fix it @donoghuc? 🙏
|
@@ -130,3 +130,18 @@ pull_request_rules: | |||
labels: | |||
- "backport" | |||
title: "[{{ destination_branch }}] {{ title }} (backport #{{ number }})" | |||
|
|||
- name: backport patches to 9.1 branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codereview: Why does the 8.19 section look different than the other?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the template was simplified by @v1v when 8.19 support was added, https://github.com/elastic/logstash/pull/17567/files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#17551 introduced the defaults, so those specific config entries per backport pull_request rule is not needed anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#17742 is the one removing those duplicated entries
I recall, I enabled some automation when a new minor was created at https://github.com/elastic/logstash/pull/16937/files#diff-9c6b820333e02ae31783c38a5a6b83e6adb6bfcdaaee16b451090b8cedf618a9R63 However, I think https://github.com/elastic/logstash/actions/runs/15888662997/job/44806654871#step:13:1 failed as it used |
Ah, i actually didnt run that job for 9.1. I (I updated the lock file directly). Good to know that is part of that workflow. I'll just do this one manualy. |
6a696b6
to
04ea91a
Compare
Update mergify data to add the newly created 9.1 branch