[metricbeat] Update doc with kube-state-metrics repository #1039
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
There was a problem hiding this comment.
Hi @yousafsyed,
The current @stable requirements is still working as long as you configured stable repo to target the new location using helm repo add stable https://charts.helm.sh/stable.
This is a temporary solution as https://charts.helm.sh/stable is not anymore updated but this is fine for now as we pinned kube-state-metrics 1.2.0 for purpose.
We had a few bad experiences before where bumping to new kube-state-metrics version broke metricbeat chart and we won't update it until we have time to fully test it.
For reference, the work to update kube-state-metrics dependency is already tracked in #733 and we intend to use the official kube-state-metrics chart from https://github.com/kubernetes/kube-state-metrics/tree/master/charts/kube-state-metrics instead of bitnami chart.
What can be improved for now?
With Helm 2, stable repo was configured by default when installing Helm client, so there was no need to document it.
With Helm 3, stable repo is no more configured by default and it's URL changed to https://charts.helm.sh/stable.
We need to explicitely mention it in the chart install section, with something like:
- Add the Elastic Helm charts repo (required for kube-state-metrics chart dependency):
helm repo add stable https://charts.helm.sh/stable
Would you be interested to update your PR to add this instruction instead?
|
@jmlrt |
Kube state metrics that were used in the metricbeat's charts were pointing towards the deprecated helm chart repository i.e "@stable" and in order to fix that we needed to point the chart towards @bitnami/kube-state-metrics which are stable and compatible with the metricbeat's deployment.
Without this small change, the charts are rendered useless since it breaks at the requirements phase.
${CHART}/tests/*.py${CHART}/examples/*/test/goss.yaml