8000 add only() to editor by elalish · Pull Request #334 · elalish/manifold · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add only() to editor #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 23, 2023
Merged

add only() to editor #334

merged 3 commits into from
Feb 23, 2023

Conversation

elalish
Copy link
Owner
@elalish elalish commented Feb 23, 2023

Follow-on to #330 - now we have OpenSCAD # functionality with show() and * functionality with only(). Ghosting out the final output gives nice context to the object shown with only().

@elalish elalish requested a review from pca006132 February 23, 2023 16:46
@elalish elalish self-assigned this Feb 23, 2023
pca006132
pca006132 reviewed Feb 23, 2023
View reviewed changes
bindings/wasm/examples/editor.d.ts
@@ -13,6 +13,7 @@
// limitations under the License.

declare function show(manifold: Manifold): Manifold;
declare function only(manifold: Manifold): Manifold;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we put the documentation for show and only here as well?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, done.

@pca006132
8000
Copy link
Collaborator

Btw, wondering what would happen if there are multiple only within 1 model. The last one wins or it will be only(union(...))?

@codecov
Copy link
codecov bot commented Feb 23, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@0704f62). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 0c5a7a1 differs from pull request most recent head 0e581fb. Consider uploading reports for the commit 0e581fb to get more accurate results

Additional details and impacted files 
@@            Coverage Diff            @@
##             master     #334   +/-   ##
=========================================
  Coverage          ?   91.50%           
=========================================
  Files             ?       32           
  Lines             ?     3730           
  Branches          ?        0           
=========================================
  Hits              ?     3413           
  Misses            ?      317           
  Partials          ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@elalish
Copy link
Owner Author
elalish commented Feb 23, 2023

It'll include each only and show mesh separately. I think that's pretty close to OpenSCAD's behavior too.

@elalish elalish merged commit 36ca7ac into master Feb 23, 2023
@elalish elalish deleted the only branch February 23, 2023 17:32
cartesian-theatrics pushed a commit to cartesian-theatrics/manifold that referenced this pull request Mar 11, 2024
@elalish
add only() to editor (elalish#334)
38f914e 
* added only() to editor

* added docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pca006132 pca006132 pca006132 left review comments

Assignees

@elalish elalish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elalish @pca006132
0