8000 Fix incorrect value for components length + test by geoffder · Pull Request #295 · elalish/manifold · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix incorrect value for components length + test #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 22, 2022
Merged

Fix incorrect value for components length + test #295

merged 1 commit into from
Dec 22, 2022

Conversation

geoffder
Copy link
Collaborator

I didn't realize I missed the correct tests on my side (in the ocaml bindings) when I made some changes to the decomposition components code. manifold_components_length has been fixed to return the value of numComponents as it should, and a test has been added for compose/decompose.

@pca006132 pca006132 merged commit bd46bfd into elalish:master Dec 22, 2022
@elalish
Copy link
Owner
elalish commented Dec 22, 2022

Thanks!

@geoffder geoffder deleted the fix_components_length branch January 25, 2023 20:19
cartesian-theatrics pushed a commit to cartesian-theatrics/manifold that referenced this pull request Mar 11, 2024
@geoffder
Fix incorrect value for components length + test (elalish#295)
6fc1188
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@geoffder @elalish @pca006132
0