JS bindings: convert mesh.triVerts to array of arrays #271
Conversation
Convert the items of mesh.triVerts to plain arrays to match the Vec3 type which is [number, number, number].
Codecov ReportBase: 92.10% // Head: 92.10% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #271 +/- ##
=======================================
Coverage 92.10% 92.10%
=======================================
Files 32 32
Lines 3446 3446
=======================================
Hits 3174 3174
Misses 272 272 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| @@ -157,8 +157,9 @@ Module.setup = function() { | |||
| const oldHalfedgeTangent = result.halfedgeTangent; | |||
| const conversion1 = v => ['x', 'y', 'z'].map(f => v[f]); | |||
| const conversion2 = v => ['x', 'y', 'z', 'w'].map(f => v[f]); | |||
| const conversion3 = v => [v[0], v[1], v[2]]; | |||
There was a problem hiding this comment.
Hmm, I must be missing something; this looks like a no-op, doesn't it? What does this change?
There was a problem hiding this comment.
This is intended to convert elements of type {0: number, 1: number, 2: number} to elements of type [number, number, number]. If this patch is not applied, the elements of result.triVerts would be generic javascript objects. With this patch, the elements will be javascript arrays. I understand the function looks like no-op, as indexing object has the same syntax as indexing array.
|
Thank you! I believe you're correct, but I also just removed that function entirely in #272. Please take a look and see if the new Mesh API I'm creating for v2.0 of the npm package will meet your needs. |
|
#272 fixes this problem, so I'm closing the issue. |
Convert the items of
mesh.triVertsto plain arrays to match theVec3type which is[number, number, number].