Improve codecov metric #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartesian-theatrics
pushed a commit
to cartesian-theatrics/manifold
that referenced
this pull request
Mar 11, 2024
assimp failing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we're not building Assimp anymore, I can add the
noinlinecompile commands to make our codecov statistics more realistic. Currently, the majority of our code is inlined, which makes it neither a hit nor a miss. Hopefully this change will make it so we're actually verifying most of our code is run in testing. Not sure if this will increase or decrease our calculated coverage, but it will make me believe it more.