remove assimp submodule #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For nix, we need to remove |
cartesian-theatrics
pushed a commit
to cartesian-theatrics/manifold
that referenced
this pull request
Mar 11, 2024
* remove assimp submodule * optionally compile meshIO * fix nix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redo of #123
Now that Assimp has been separated from our bindings and tests, it no longer needs to be a submodule at all. In fact it is now only a dependency of
meshIO, which is no longer a part of the core library, but simply an optional test/debug helper. In order to be able to export test results as 3D models (e.g. GLB), you'll need to havelibassimp-devinstalled by your package manager and enable theMANIFOLD_EXPORTcompile flag.I like this because the
Manifoldlibrary is about computational geometry, not file I/O. This makes that boundary much more clear and also simplifies and speeds up our build process.