10000 disable branch coverage by elalish · Pull Request #142 · elalish/manifold · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

disable branch coverage #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 21, 2022
Merged

disable branch coverage #142

merged 5 commits into from
Jun 21, 2022

Conversation

elalish
Copy link
Owner
@elalish elalish commented Jun 20, 2022 •
edited
Loading

I really like the coverage report, especially in combination with the codecov extension to the sourcegraph browser extension that let's me visualize the coverage line-by-line right in Github! But it was coming up with a lot of things having ~50% coverage, and it was claiming lots of lines were "partial coverage". It seems this is largely because of internal exception handling code and probably has something to do with why branch coverage is disabled by default in lcov: https://stackoverflow.com/a/43726240

I'm switching it here to see if this gives us a less messy coverage report that's more actionable. What do you think, @pca006132?

@elalish elalish self-assigned this Jun 20, 2022
@pca006132
Copy link
Collaborator

Oh I'm fine with this, iirc I just copied some lcov commands from the web randomly. Btw maybe you can add the coverage badge to the README file, that badge is also a link to the coverage report so others can look at it easily.

@codecov-commenter
Copy link
codecov-commenter commented Jun 20, 2022 •
edited
Loading

Codecov Report

Merging #142 (3e5ab8e) into master (65b6057) will increase coverage by 25.03%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #142       +/-   ##
===========================================
+ Coverage   68.54%   93.58%   +25.03%     
===========================================
  Files         161       32      -129     
  Lines        4146     3256      -890     
  Branches     1831        0     -1831     
===========================================
+ Hits         2842     3047      +205     
+ Misses        656      209      -447     
+ Partials      648        0      -648
Impacted Files Coverage Δ
utilities/src/detect_cuda.cpp 85.71% <0.00%> (-14.29%) ⬇️
...y/thrust/thrust/system/detail/generic/distance.inl
...st/thrust/system/detail/sequential/binary_search.h
...ird_party/thrust/thrust/system/cuda/detail/count.h
third_party/glm/glm/detail/_vectorize.hpp
...ust/thrust/system/detail/sequential/general_copy.h
...ystem/cuda/detail/internal/copy_device_to_device.h
third_party/glm/glm/detail/type_vec4.inl
third_party/thrust/thrust/detail/copy.inl
third_party/thrust/thrust/detail/numeric_traits.h
... and 158 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65b6057...3e5ab8e. Read the comment docs.

@elalish elalish merged commit aa5badd into master Jun 21, 2022
@elalish elalish deleted the coverage branch June 21, 2022 00:48
cartesian-theatrics pushed a commit to cartesian-theatrics/manifold that referenced this pull request Mar 11, 2024
@elalish
Merge pull request elalish#142 from elalish/coverage
80de45d 
disable branch coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@elalish elalish

Labels
None yet
4890
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elalish @pca006132 @codecov-commenter
0