8000 fix pyi vert_properties type by Trzeth · Pull Request #1291 · elalish/manifold · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix pyi vert_properties type #1291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix pyi vert_properties type #1291

wants to merge 2 commits into from
+11 −4

Conversation

Trzeth
Copy link
Contributor
@Trzeth Trzeth commented Jun 25, 2025

Fix #1290.

Before:
PyCharm
image
VSCode
image

After
image
image

@codecov Codecov
Copy link
codecov bot commented Jun 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.15%. Comparing base (8c63b86) to head (c95246a).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1291   +/-   ##
=======================================
  Coverage   92.15%   92.15%           
=======================================
  Files          32       32           
  Lines        5981     5981           
=======================================
  Hits         5512     5512           
  Misses        469      469

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

elalish
elalish approved these changes Jun 25, 2025
View reviewed changes
Copy link
Owner
@elalish elalish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pca006132
Copy link
Collaborator

I think there are more stubs that should be fixed, but this is probably ok for now.

@Trzeth
Copy link
Contributor Author
Trzeth commented Jun 26, 2025

I'm gonna check further. Let me solve it in this pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elalish elalish elalish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The .pyi stub file appears to be incorrect
3 participants
@Trzeth @pca006132 @elalish
0