Remove per-error hacks in favor of a "disable Werror" option #1223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For users who are just looking to build and aren't interested in failing the build due to warnings, provide a MANIFOLD_STRICT option to control it. By default it will remain on, since developers will generally want to fix errors found, but for user projects or those working with older compilers setting -DMANIFOLD_STRICT=OFF will allow them to avoid build failure when warnings are spurious. Also should eliminate most of the motivation to suppress specific warnings per-file, although that may still be desirable in some specific instances if the newest compilers are the ones generating verifiably incorrect/unavoidable errors.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1223 +/- ##
=======================================
Coverage 92.19% 92.19%
=======================================
Files 31 31
Lines 5985 5985
=======================================
Hits 5518 5518
Misses 467 467 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For users who are just looking to build and aren't interested in failing the build due to warnings, provide a MANIFOLD_STRICT option to control it.
By default it will remain on, since developers will generally want to fix errors found, but for user projects or those working with older compilers setting -DMANIFOLD_STRICT=OFF will allow them to avoid build failure when warnings are spurious.
Also should eliminate most of the motivation to suppress specific warnings per-file, although that may still be desirable in some specific instances if the newest compilers are the ones generating verifiably incorrect/unavoidable errors.