Suppress quickhull.cpp warnings with g++ compiler #1218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Observed with gcc 12 (array-bounds) and 13 (stringop-overflow):
inlined from ‘void manifold::QuickHull::createConvexHalfedgeMesh()’ at /home/user/manifold/src/quickhull.cpp:442:40:
/usr/include/c++/13/bits/stl_algobase.h:931:18: error: ‘void* __builtin_memset(void*, int, long unsigned int)’ specified bound 18446744073709551608 exceeds maximum object size 9223372036854775807 [-Werror=stringop-overflow=]
931 | *__first = __tmp;
| ~~~~~~~~~^~~~~~~
inlined from ‘void manifold::QuickHull::createConvexHalfedgeMesh()’ at /home/user/manifold/src/quickhull.cpp:442:40:
/usr/include/c++/12/bits/stl_algobase.h:922:18: error: ‘void* __builtin_memset(void*, int, long unsigned int)’ pointer overflow between offset 0 and size 18446744073709551608 [-Werror=array-bounds]
922 | *__first = __tmp;
| ~~~~~~~~~^~~~~~~
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1218 +/- ##
=======================================
Coverage 92.19% 92.19%
=======================================
Files 31 31
Lines 5985 5985
=======================================
Hits 5518 5518
Misses 467 467 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pca006132
approved these changes
Apr 3, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observed with gcc 12 (array-bounds) and 13 (stringop-overflow):
inlined from ‘void manifold::QuickHull::createConvexHalfedgeMesh()’ at /home/user/manifold/src/quickhull.cpp:442:40: /usr/include/c++/13/bits/stl_algobase.h:931:18: error: ‘void* __builtin_memset(void*, int, long unsigned int)’ specified bound 18446744073709551608 exceeds maximum object size 9223372036854775807 [-Werror=stringop-overflow=]
931 | *__first = __tmp;
| ~~~~~~~~~^~~~~~~
inlined from ‘void manifold::QuickHull::createConvexHalfedgeMesh()’ at /home/user/manifold/src/quickhull.cpp:442:40: /usr/include/c++/12/bits/stl_algobase.h:922:18: error: ‘void* __builtin_memset(void*, int, long unsigned int)’ pointer overflow between offset 0 and size 18446744073709551608 [-Werror=array-bounds]
922 | *__first = __tmp;
| ~~~~~~~~~^~~~~~~