8000 Fix Revolve clipping by elalish · Pull Request #1200 · elalish/manifold · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix Revolve clipping #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025
Merged

Fix Revolve clipping #1200

merged 1 commit into from
Mar 27, 2025

Conversation

elalish
Copy link
Owner
@elalish elalish commented Mar 27, 2025

Fixes #1198

Just a sign error, plus some minor cleanup that clangd noticed.

@elalish elalish requested a review from pca006132 March 27, 2025 08:25
@elalish elalish self-assigned this Mar 27, 2025
Copy link
codecov bot commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.29%. Comparing base (bdb0b88) to head (30d5b09).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1200   +/-   ##
=======================================
  Coverage   92.29%   92.29%           
=======================================
  Files          31       31           
  Lines        5972     5972           
=======================================
  Hits         5512     5512           
  Misses        460      460           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@elalish elalish merged commit 4443993 into master Mar 27, 2025
27 checks passed
@elalish elalish mentioned this pull request May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revolve not clipping polygon correctly.
2 participants
0