Fix Cross Section Mirror and add Test #1206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1206 +/- ##
=======================================
Coverage 92.23% 92.23%
=======================================
Files 31 31
Lines 5988 5988
=======================================
Hits 5523 5523
Misses 465 465 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I'm not familiar enough to know what's going wrong with the Mac TBB checks given how little I changed, so I leave it to others, assuming those are actual errors that need fixing. |
|
Those are unrelated, we will fix them soon to unblock these PRs. |
|
you can merge the master branch and push now |
elalish
requested changes
Mar 30, 2025
test/cross_section_test.cpp
Outdated
| EXPECT_FLOAT_EQ(result_a.Volume(), 0.); | ||
| EXPECT_FLOAT_EQ(result_a2.Volume(), 0.); | ||
| EXPECT_FLOAT_EQ(result_b.Volume(), 0.); | ||
| EXPECT_FLOAT_EQ(result_b2.Volume(), 0.); |
There was a problem hiding this comment.
This is a little complicated - could we use a bounding box check instead of all these boolean ops? I also don't think we need to export all these models.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1204
Removes an extraneous
la::abscall that would result in incorrect behavior for axes with mixed sign components (i.e. (-1, 1)) and adds a test to catch it.Note: what initially caused me to think something was wrong was that mirroring something in quadrant 1 across the axis given by (1,1) ended up in quadrant 3. After looking at the code more intently, it appears this is actually intended behavior and the provided axis vector should be interpreted as being the normal to the axis we are mirroring over, not tangent to the axis.
I believe this is done to avoid having to calculate any angles and seems like a reasonable thing to do; however, I was caught off guard because in 2D I would typically think of defining a line in terms of it's tangent vector. Unclear if this is just me having some bad intuition or if some additional clarification could also be useful.