parallel CreateHalfedges #1188
Merged
parallel CreateHalfedges #1188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1188 +/- ##
=======================================
Coverage 91.62% 91.62%
=======================================
Files 32 32
Lines 6067 6069 +2
=======================================
+ Hits 5559 5561 +2
Misses 508 508 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
elalish
approved these changes
Mar 13, 2025
src/impl.cpp
Outdated
|
|
||
| #if MANIFOLD_PAR == 1 | ||
| Vec<std::pair<int, int>> ranges; | ||
| int increment = std::min( |
src/impl.cpp
Outdated
| }; | ||
| int end = 0; | ||
| while (end < numEdge) { | ||
| int start = end; |
src/impl.cpp
Outdated
| } | ||
| for_each(ExecutionPolicy::Par, ranges.begin(), ranges.end(), | ||
| [&](const std::pair<int, int>& range) { | ||
| auto [start, end] = range; |
There was a problem hiding this comment.
wow, this syntax is starting to look like TS! C++ is definitely improving.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turns out to be quite simple to parallelize. Not a huge gain though.