-
Notifications
You must be signed in to change notification settings - Fork 138
Misc changes #1162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc changes #1162
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -432,12 +432,10 @@ TEST(Boolean, Precision2) { | |
|
||
TEST(Boolean, DISABLED_SimpleCubeRegression) { | ||
ManifoldParams().intermediateChecks = true; | ||
ManifoldParams().processOverlaps = false; | ||
Manifold result = | ||
Manifold::Cube().Rotate(-0.10000000000000001, 0.10000000000000001, -1.) + | ||
Manifold::Cube() - | ||
Manifold::Cube().Rotate(-0.10000000000000001, -0.10000000000066571, -1.); | ||
EXPECT_EQ(result.Status(), Manifold::Error::NoError); | ||
ManifoldParams().intermediateChecks = false; | ||
ManifoldParams().processOverlaps = true; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's the trouble with this test? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -295,13 +295,17 @@ TEST(Samples, Sponge4) { | |
#endif | ||
#endif | ||
|
||
TEST(Samples, DISABLED_CondensedMatter16) { | ||
TEST(Samples, CondensedMatter16) { | ||
// FIXME: Triangulation can be invalid | ||
bool old = PolygonParams().processOverlaps; | ||
PolygonParams().processOverlaps = true; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As for the bad triangulation - did you output that poly with full precision? It says they exactly share a vertex position, but I'm guessing they actually overlap slightly? Because otherwise I think the triangulator should work. When you find polys like this and they turn out to actually be epsilon-valid, go ahead and add them to our polygon test corpus. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just updated, but it is indeed sharing the exact same vertex position:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That looks like a good test for the corpus. I need to come back and debug that one. |
||
Manifold cm = CondensedMatter(16); | ||
CheckGL(cm); | ||
#ifdef MANIFOLD_EXPORT | ||
if (options.exportModels) | ||
ExportMesh("condensedMatter16.glb", cm.GetMeshGL(), {}); | ||
#endif | ||
PolygonParams().processOverlaps = old; | ||
} | ||
|
||
TEST(Samples, CondensedMatter64) { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Want to add instructions to our release checklist?