unified ManifoldParams and PolygonParams #1167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elalish
requested changes
Feb 25, 2025
src/polygon.cpp
Outdated
| @@ -528,7 +527,7 @@ class EarClip { | |||
|
|
|||
| void PrintVert() const { | |||
| #ifdef MANIFOLD_DEBUG | |||
| if (!params.verbose) return; | |||
| if (!ManifoldParams().verbose) return; | |||
There was a problem hiding this comment.
We'll need to separate the verbosity or have levels or something. The triangulator is orders of magnitude more verbose than the Boolean is.
There was a problem hiding this comment.
it is now an int
|
Oh, I forgot to disable that test :P |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1167 +/- ##
==========================================
- Coverage 91.70% 91.60% -0.11%
==========================================
Files 32 32
Lines 5980 5989 +9
==========================================
+ Hits 5484 5486 +2
- Misses 496 503 +7 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old way of specifying parameters for manifold and polygon separately is quite confusing. This merges them, and removed
PolygonParamsall together.This is a small breaking that hopefully no one is using, except our own testing code. That said, the next release should still bump the minor version (3.1.0) together with other changes in decimation etc.