Early return when result size too large #1166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pca006132
commented
Feb 25, 2025
| @@ -531,6 +533,11 @@ Boolean3::Boolean3(const Manifold::Impl &inP, const Manifold::Impl &inQ, | |||
| p2q0.Sort(); | |||
| PRINT("p2q0 size = " << p2q0.size()); | |||
|
|
|||
| if (3 * p1q2_.size() + 3 * p2q1_.size() > INT_MAX_SZ) { | |||
There was a problem hiding this comment.
This is the specific expression that can overflow integers.
| @@ -573,6 +580,11 @@ Boolean3::Boolean3(const Manifold::Impl &inP, const Manifold::Impl &inQ, | |||
| Intersect12(inQ, inP, s20, p2q0, s11, p1q1, z20, xyzz11, p2q1_, false); | |||
| PRINT("x21 size = " << x21_.size()); | |||
|
|
|||
| if (x12_.size() > INT_MAX_SZ || x21_.size() > INT_MAX_SZ) { | |||
There was a problem hiding this comment.
x12 and x21 can be at most the size of the sparse indices, which is at most n^2 and can cause overflow elsewhere.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1166 +/- ##
==========================================
- Coverage 91.70% 91.60% -0.11%
==========================================
Files 32 32
Lines 5980 5990 +10
==========================================
+ Hits 5484 5487 +3
- Misses 496 503 +7 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1164.
I have looked at the code for cases where the result size can be too large, and it seems that not a lot can cause integer overflow if we limit the input size (halfedge count).
@howardt can you check if this can avoid the crash?