8000 fix default JS parameter binding for simplify by elalish · Pull Request #1146 · elalish/manifold · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix default JS parameter binding for simplify #1146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2025
Merged

fix default JS parameter binding for simplify #1146

merged 1 commit into from
Feb 16, 2025

Conversation

elalish
Copy link
Owner
@elalish elalish commented Feb 16, 2025

Fixes #1145

@elalish elalish self-assigned this Feb 16, 2025
Copy link
codecov bot commented Feb 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.70%. Comparing base (a857f00) to head (20adca6).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1146   +/-   ##
=======================================
  Coverage   91.70%   91.70%           
=======================================
  Files          30       30           
  Lines        5931     5931           
=======================================
  Hits         5439     5439           
  Misses        492      492           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elalish elalish merged commit c149dd5 into master Feb 16, 2025
27 checks passed
@elalish elalish deleted the jsSimplify branch February 16, 2025 09:06
@elalish elalish mentioned this pull request May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

js bindings: CrossSection.simplify() requires parameter even though the docs say its optional
1 participant
0