8000 CI updates by pca006132 · Pull Request #1123 · elalish/manifold · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

CI updates #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 26, 2024
Merged

CI updates #1123

merged 6 commits into from
Dec 26, 2024

Conversation

pca006132
Copy link
Collaborator
  1. Use consistent names for all CI jobs.
  2. Removed standalone C binding test (as it is tested everywhere already).
  3. Build MANIFOLD_DEBUG=ON variant for wasm as well (not uploaded, just for tests)
  4. Check for windows dll location when BUILD_SHARED_LIBS=ON.

@codecov Codecov
Copy link
codecov bot commented Dec 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.54%. Comparing base (209350f) to head (810400f).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1123   +/-   ##
=======================================
  Coverage   91.54%   91.54%           
=======================================
  Files          30       30           
  Lines        5904     5904           
=======================================
  Hits         5405     5405           
  Misses        499      499

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pca006132
Copy link
Collaborator Author

@elalish this should be included in the patch release due to fixing msvc dll stuff.

elalish
elalish approved these changes Dec 26, 2024
View reviewed changes
Copy link
Owner
@elalish elalish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Yes, let's go ahead and get this in.

@elalish elalish merged commit be1dec2 into master Dec 26, 2024
28 checks passed
@elalish elalish deleted the ci-update branch December 26, 2024 17:04
@elalish elalish mentioned this pull request Dec 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elalish elalish elalish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pca006132 @elalish
0