8000 python: update nanobind version requirement by pca006132 · Pull Request #1120 · elalish/manifold · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

python: update nanobind version requirement #1120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 23, 2024
Merged

python: update nanobind version requirement #1120

merged 1 commit into from
Dec 23, 2024

Conversation

pca006132
Copy link
Collaborator

Fixes #1119.

@pbsds
Copy link
pbsds commented Dec 23, 2024 •
edited
Loading

Thank you for the swift response 😄

Package distributions such as nixpkgs really appreciate it if you tag dependency bumps like this with e.g. a patch release. If this is not possible, then we can always cherry-pick the change :)

@codecov Codecov
Copy link
codecov bot commented Dec 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.54%. Comparing base (f48111c) to head (4001dc0).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1120   +/-   ##
=======================================
  Coverage   91.54%   91.54%           
=======================================
  Files          30       30           
  Lines        5904     5904           
=======================================
  Hits         5405     5405           
  Misses        499      499

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pca006132
Copy link
Collaborator Author

Package distributions such as nixpkgs really appreciate it if you tag dependency bumps like this with e.g. a patch release. If this is not possible, then we can always cherry-pick the change :)

Sounds good to me. @elalish what do you think?

@pca006132 pca006132 merged commit 1917ce0 into master Dec 23, 2024
25 checks passed
@pca006132 pca006132 deleted the update-nanobind branch December 23, 2024 13:14
@pca006132
Copy link
Collaborator Author
pca006132 commented Dec 23, 2024 •
edited
Loading

@pbsds I will wait until @elalish respond, probably in a day. (for the patch release)

@elalish
Copy link
Owner
elalish commented Dec 23, 2024

Sure. Somehow we've had 50 PRs already since v3.0 (!). A few good bug fixes in there too - probably good to put out a patch anyway. @pca006132 Want me to write some release notes or do you want to do it?

@pca006132
Copy link
Collaborator Author

@elalish yeah you can do it, I wanr to spend more time on the sdf stuff.

@elalish elalish mentioned this pull request Dec 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please support nanobind 2.4.0
3 participants
@pca006132 @pbsds @elalish
0