run tests for nix #1094
8000run tests for nix #1094
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1094 +/- ##
=======================================
Coverage 91.87% 91.87%
=======================================
Files 30 30
Lines 5883 5883
=======================================
Hits 5405 5405
Misses 478 478 ☔ View full report in Codecov by Sentry. |
| @@ -106,6 +106,7 @@ | |||
| "-DBUILD_SHARED_LIBS=ON" | |||
| "-DMANIFOLD_PAR=${if parallel then "ON" else "OFF"}" | |||
| ]; | |||
| doCheck = true; | |||
There was a problem hiding this comment.
build_mxe still looks like it's not testing - also build_mac_..._subdir, unless that's intentional?
There was a problem hiding this comment.
mxe cannot be tested: we are building some windows exe on linux. at least we cannot test it without another job on windows...
bulid_mac_..._subdir... is just to test the cmake consumer, see if we can build when put inside a subdirectory in a larger project.
| @@ -106,6 +106,7 @@ | |||
| "-DBUILD_SHARED_LIBS=ON" | |||
| "-DMANIFOLD_PAR=${if parallel then "ON" else "OFF"}" | |||
| ]; | |||
| doCheck = true; | |||
There was a problem hiding this comment.
And any idea why build_nix_tbb is so slow? It looks like it's building all of TBB before it even gets to Manifold...
There was a problem hiding this comment.
I added the latest tbb version for emscripten, forgot why I also use it for other native builds... fixed.
No description provided.