Fix action #1059
Merged
Fix action #1059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw this is untested, but if it works it should be correct? (assuming the documentation for the download artifact action is correct). Will go to sleep now, hope that everything just work. |
<
8000
details class="details-overlay details-reset position-relative d-inline-block">
Copy link
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1059 +/- ##
==========================================
- Coverage 91.84% 84.69% -7.15%
==========================================
Files 37 62 +25
Lines 4976 9685 +4709
Branches 0 1050 +1050
==========================================
+ Hits 4570 8203 +3633
- Misses 406 1482 +1076 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
I just merge it and see how the deployment goes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1058.
build_wheels.yamlaction a bit. The architecture is default to native only, so we don't have to explicitly tell x86_64 to only run x86_64 builds.Previously, the deployment event runs when we push to master, i.e. when a PR is merged. When there is only one active PR, things are fine because the latest wasm artifact is the expected one. However, when there are multiple events, the CI will search for the last artifact, which may not be the result from the merged PR. We now try to wait until the master branch CI workflow is complete, and limit the artifact search to artifact produced by workflow run from the master branch. This should avoid downloading an incorrect artifact.
For publish_npm, I can't make it wait for the latest master branch without using external actions like https://github.com/marketplace/actions/wait-on-check. And I feel like we probably won't be pushing to master with large changes to wasm binaries and immediately do a publish, so it should be fine...?