switched property indexing from vector to scalar #1016
Conversation
| @@ -52,15 +52,10 @@ void manifold_material_set_metalness(ManifoldMaterial *mat, double metalness) { | |||
| from_c(mat)->metalness = metalness; | |||
| } | |||
|
|
|||
| void manifold_material_set_color(ManifoldMaterial *mat, ManifoldVec4 color) { | |||
| void manifold_material_set_color(ManifoldMaterial *mat, ManifoldVec3 color) { | |||
There was a problem hiding this comment.
Just taking a look on my phone from the hospital with a suddenly one month early (healthy) new born daughter, but this looks ok to me. The from_c overload should be doing its job here so nothing needs to change past the type.
There was a problem hiding this comment.
Thanks, and congrats! My first daughter was also a month early - had to spend a week in the NICU, which wasn't much fun. But she's fine and it's hard to believe she's ten now. Good job on getting out of grad school - want to share your dissertation? Enjoy your family time, and let me know if you want a Google referral.
|
Still trying to check the emails! Sorry I've still been AWOL, PhD is done, and now baby is born. I hope I can make space to bring back some OSS and extracurricular coding back into my life before too long, but life continues to provide new challenges. |
src/manifold.cpp
Outdated
| @@ -302,7 +301,7 @@ Manifold::Manifold(const MeshGL64& meshGL64) | |||
| * front/back side. Each channel must be >= 3 and < numProp, and all original | |||
| for (int i : {0, 1, 2}) { | ||
| const vec3& uvw = {0.5, 0.5, 0.0}; | ||
| const double alpha = std::min(uvw[0], std::min(uvw[1], uvw[2])); | ||
| options.mat.vertColor[out.triVerts[3 * tri + i]] = |
There was a problem hiding this comment.
do we have color for this now?
There was a problem hiding this comment.
No, but it also wasn't working before - I realized this was leftover code that wasn't really doing much.
Fixes #664 (reply in thread)
The bindings probably still need some work...