wasm: fix CrossSection slice and project bindings #930
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #930 +/- ##
==========================================
- Coverage 91.84% 88.29% -3.55%
==========================================
Files 37 62 +25
Lines 4976 8643 +3667
Branches 0 1046 +1046
==========================================
+ Hits 4570 7631 +3061
- Misses 406 1012 +606 ☔ View full report in Codecov by Sentry. |
bindings/wasm/bindings.js
Outdated
| @@ -284,11 +284,17 @@ Module.setup = function() { | |||
| }; | |||
|
|
|||
| Module.Manifold.prototype.slice = function(height = 0.) { | |||
| return Module.CrossSection(this._Slice(height)); | |||
| const polygonsVec = this._Slice(height); | |||
| const result = new CrossSectionCtor(polygonsVec, 2 /* positive */); | |||
There was a problem hiding this comment.
How about fillRule2Int('Positive') as elsewhere, for maintainability?
ec020bd to
d8e590f
Compare
|
I leaned into the default yellow rendering and made a cheesy example. Let me know if that works for you. Also, how do I run the auto code formatter to fix the one broken CI check? I installed |
|
Would you mind adding a screenshot? As to formatting, it looks like our |
|
|
a9c034a to
8c80049
Compare
8c80049 to
684eadd
Compare
| @@ -51,6 +51,34 @@ export const examples = { | |||
| return result; | |||
| }, | |||
|
|
|||
| Auger: function() { | |||
There was a problem hiding this comment.
Thanks for the example! But I'm also really picky about public examples, so I went ahead and made my own instead. Please don't feel slighted; it's just my own aesthetics.
| @@ -153,7 +153,7 @@ jobs: | |||
| cp ../manifold.* ./dist/ | |||
| - name: Upload WASM files | |||
| uses: actions/upload-artifact@v4 | |||
| if: matrix.exception == 'ON' | |||
| if: matrix.exception == 'ON' && github.event_name == 'push' | |||
There was a problem hiding this comment.
Hopefully this will fix the accidental update problem.
Resolves #929 by calling the
CrossSectionCtordirectly. These functions already have the vector returned by the_Slice/_Projectso thepolygons2vecisn't needed. I just copied what theCrossSectionwrapper did w/out it.I'm not sure if the memory management with
disposePolygonsis correct, but my tests in with a local ManifoldCAD work after this change.I also couldn't figure out how to add new tests. AFAICT, it's just running the examples? It might be worth adding a
sliceexample anyway. Happy to add as part of this PR if you point me in the right direction.