Fix missing 'this' for property access in wasm bindings #914

dsafa · 2024-09-04T22:14:22Z

The js bindings throw numProp is not defined when trying to use Mesh.position() or Mesh.extras(). They were just missing a this

google-cla · 2024-09-04T22:14:25Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

codecov · 2024-09-04T22:27:38Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.76%. Comparing base (d437097) to head (5da706d).
Report is 85 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #914      +/-   ##
==========================================
- Coverage   91.84%   89.76%   -2.08%     
==========================================
  Files          37       66      +29     
  Lines        4976     9813    +4837     
  Branches        0     1055    +1055     
==========================================
+ Hits         4570     8809    +4239     
- Misses        406     1004     +598

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dsafa · 2024-09-04T23:08:46Z

hmm running format.sh is not doing anything :/

elalish

Thanks! I generally just run clang-format inside of VSCode. If all else fails you can just copy the corrected lines from the CI's format checker and paste them in place.

dsafa · 2024-09-05T00:14:06Z

Thanks, that works. fixed.

I took a look and bash needs globstar option set for ** to work it seems. So I enabled it but then node_modules starts matching the pattern and I'm not familiar enough to know the best way to ignore that so I'll just leave this for anyone else if they encounter the same thing and want to fix it

elalish

Thanks!

Fix missing 'this' for property access

087cce3

elalish approved these changes Sep 4, 2024

View reviewed changes

fix formatting

5da706d

elalish approved these changes Sep 5, 2024

View reviewed changes

elalish merged commit e9c065b into elalish:master Sep 5, 2024
22 checks passed

dsafa deleted the fix-this-wasm-b 6F95 indings branch September 10, 2024 22:24

elalish mentioned this pull request Nov 5, 2024

v3.0 #1024

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix missing 'this' for property access in wasm bindings #914

Fix missing 'this' for property access in wasm bindings #914

Fix missing 'this' for property access in wasm bindings #914

Fix missing 'this' for property access in wasm bindings #914

Conversation

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment