use custom file format for polygon tests #913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #913 +/- ##
==========================================
- Coverage 91.84% 88.40% -3.44%
==========================================
Files 37 62 +25
Lines 4976 8660 +3684
Branches 0 1059 +1059
==========================================
+ Hits 4570 7656 +3086
- Misses 406 1004 +598 ☔ View full report in Codecov by Sentry. |
|
Probably need to use https://emscripten.org/docs/porting/files/packaging_files.html#packaging-files for wasm. Will try it later tonight. |
elalish
requested changes
Sep 4, 2024
|
I have no idea why the formatting thing is now failing... |
9022d1d to
47c6e64
Compare
elalish
approved these changes
Sep 5, 2024
| @@ -144,12 +144,12 @@ void PrintFailure(const std::exception &e, const PolygonsIdx &polys, | |||
| std::cout << "-----------------------------------" << std::endl; | |||
| std::cout << "Triangulation failed! Precision = " << precision << std::endl; | |||
| std::cout << e.what() << std::endl; | |||
| if (triangles.size() > 1000) { | |||
| if (triangles.size() > 1000 && !PolygonParams().verbose) { | |||
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #910
see #911 (comment)