Add *.pc file for easier use in non-cmake environments. #901
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #901 +/- ##
==========================================
- Coverage 91.84% 87.26% -4.58%
==========================================
Files 37 66 +29
Lines 4976 9442 +4466
Branches 0 1033 +1033
==========================================
+ Hits 4570 8240 +3670
- Misses 406 1202 +796 ☔ View full report in Codecov by Sentry. |
1ca1757 to
3c4a712
Compare
|
Thanks. Maybe we can add a simple test for *.pc as well? Similar to https://github.com/elalish/manifold/blob/master/test-cmake.sh. |
3c4a712 to
7f77a78
Compare
|
Done, added While at it, I discovered an ambiguity that cmake allows, which is that cmake, allows to include So only |
pkg-config is the common way how to find cflags and library flags for projects not using cmake.
7f77a78 to
0620985
Compare
Yeah, we were thinking about fixing this in v3.0. We should also fix the include statements in other header files as well, but that may require changing the file structure in our repo, and I am not sure what is the best way of solving this. |
|
Nothing to add right now, ready to merge. |
pkg-config is the common way how to find cflags and library flags for projects not using cmake.