8000 C bindings are required to build Python package by jonathanhogg · Pull Request #883 · elalish/manifold · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

C bindings are required to build Python package #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 3, 2024
Merged

C bindings are required to build Python package #883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdf7b2a
Don't attempt to build C bindings for Python package
jonathanhogg Aug 1, 2024
653cc25
Add workflow stage to do a test build of the SDist
jonathanhogg Aug 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/build_wheels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: build_wheels

on:
on:
release:
types: [published]
workflow_dispatch:
Expand Down Expand Up @@ -35,6 +35,8 @@ jobs:
submodules: recursive
- name: Build SDist
run: pipx run build --sdist
- name: Confirm SDist can be built
run: pip wheel dist/*.tar.gz
- uses: actions/upload-artifact@v4
with:
name: python-sdist
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ sdist.exclude = [
"bindings/python/third_party/nanobind/docs/",
]
wheel.packages = ["manifold3d"]
cmake.args = ["-DMANIFOLD_PYBIND=ON", "-DMANIFOLD_PAR=TBB", "-DMANIFOLD_TEST=OFF", "-DBUILD_SHARED_LIBS=OFF"]
cmake.args = ["-DMANIFOLD_PYBIND=ON", "-DMANIFOLD_CBIND=OFF", "-DMANIFOLD_PAR=TBB", "-DMANIFOLD_TEST=OFF", "-DBUILD_SHARED_LIBS=OFF"]
install.components = ["bindings"]

[tool.cibuildwheel]
Expand Down
Loading
0