8000 windows compatibility support by yetigit · Pull Request #88 · elalish/manifold · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

windows compatibility support #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 19, 2022
Merged

windows compatibility support #88

merged 3 commits into from
Apr 19, 2022

Conversation

yetigit
Copy link
Contributor
@yetigit yetigit commented Mar 16, 2022

had a ton of divide by zero errors so had to replace it with some other stuff

< 8000 div class="avatar-parent-child TimelineItem-avatar d-none d-md-block"> @yetigit
Copy link
Contributor Author
yetigit commented Mar 16, 2022

the whole thing was built using vcpkg to commit b7a1088ae9bfed114dd36e0d60ddb3db3b7a4b7f (for the dependencies of cgal) ; with vcpkg as the toolchain file to cmake.
I then modified extras missing from the cmake build , from a couple of vs projects ,
like the glm include folder path and assimp include path as well as its static lib path

@elalish
Copy link
Owner
elalish commented Mar 18, 2022

Thanks! I don't have a windows box, so haven't gotten to try with their compilers myself. Is there an easy way around the path differences in Windows vs Linux? It might be simpler to use WSL2. Also, are the two issues you opened related to your PR here? Might be easier to discuss them here. Definitely seems like something is off.

@yetigit
Copy link
Contributor Author
yetigit commented Mar 18, 2022

Also, are the two issues you opened related to your PR here? Might be easier to discuss them here. Definitely seems like something is off.

yes it's related; if you can run the full loop of perftest on your system with these changes then i guess it's okayish
but then it would mean just being on windows is the culprit , because of some different instructions ?

@elalish
Copy link
Owner
elalish commented Mar 19, 2022

@yetigit Have you tried installing the CUDA toolkit and compiling with nvcc? Even if you don't have an NVidia GPU, it can compile for CPU only and might have better support for Thrust. Or is that what you're already doing?

@yetigit
Copy link
Contributor Author
yetigit commented Mar 21, 2022

@elalish re , yes it was compiled w nvcc , windows flavored CUDA right from the toolkit

@elalish
Copy link
Owner
elalish commented Mar 22, 2022

@yetigit Hmm, I wonder what the compiler difference is between MS and gcc... I'll need to find a way to run them side-by-side to properly debug. Think you can try to get the relative path thing working in Windows so we can merge this PR?

< 8000 /td>

@yetigit
Copy link
Contributor Author
yetigit commented Apr 14, 2022

@yetigit Hmm, I wonder what the compiler difference is between MS and gcc... I'll need to find a way to run them side-by-side to properly debug. Think you can try to get the relative path thing working in Windows so we can merge this PR?

done b65b445

Copy link
Owner
@elalish elalish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@@ -20,7 +20,7 @@
using namespace manifold;

int main(int argc, char **argv) {
for (int i = 0; i < 8; ++i) {
for (int i = 0; i < 3; ++i) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't need to change, but it doesn't really hurt anything.

@elalish elalish merged commit 92bb669 into elalish:master Apr 19, 2022
cartesian-theatrics pushed a commit to cartesian-theatrics/manifold that referenced this pull request Mar 11, 2024
windows compatibility support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0