-
Notifications
You must be signed in to change notification settings - Fork 137
windows compatibility support #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
the whole thing was built using vcpkg to commit b7a1088ae9bfed114dd36e0d60ddb3db3b7a4b7f (for the dependencies of cgal) ; with vcpkg as the toolchain file to cmake. |
Thanks! I don't have a windows box, so haven't gotten to try with their compilers myself. Is there an easy way around the path differences in Windows vs Linux? It might be simpler to use WSL2. Also, are the two issues you opened related to your PR here? Might be easier to discuss them here. Definitely seems like something is off. |
yes it's related; if you can run the full loop of perftest on your system with these changes then i guess it's okayish |
@yetigit Have you tried installing the CUDA toolkit and compiling with nvcc? Even if you don't have an NVidia GPU, it can compile for CPU only and might have better support for Thrust. Or is that what you're already doing? |
@elalish re , yes it was compiled w nvcc , windows flavored CUDA right from the toolkit |
@yetigit Hmm, I wonder what the compiler difference is between MS and gcc... I'll need to find a way to run them side-by-side to properly debug. Think you can try to get the relative path thing working in Windows so we can merge this PR? < 8000 /td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@@ -20,7 +20,7 @@ | |||
using namespace manifold; | |||
|
|||
int main(int argc, char **argv) { | |||
for (int i = 0; i < 8; ++i) { | |||
for (int i = 0; i < 3; ++i) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't need to change, but it doesn't really hurt anything.
windows compatibility support
had a ton of divide by zero errors so had to replace it with some other stuff