Rename operator""_z to _uz per P0330R8, and move into namespace manifold #869
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #869 +/- ##
==========================================
- Coverage 91.84% 90.07% -1.77%
==========================================
Files 37 65 +28
Lines 4976 9156 +4180
Branches 0 950 +950
==========================================
+ Hits 4570 8247 +3677
- Misses 406 909 +503 ☔ View full report in Codecov by Sentry. |
|
Thanks! If it builds, it is fine, we do not have specific tests about this. I think you need to format the code using clang-format as well as agree to the CLA. |
src/utilities/include/public.h
Outdated
| /** | ||
| * Stand-in for C++23's operator""uz (P0330R8)[https://wg21.link/P0330R8]. | ||
| */ | ||
| [[nodiscard]] constexpr std::size_t operator""_uz(unsigned long long n) noexcept { return n; } |
There was a problem hiding this comment.
This caused me to look up [[nodiscard]] - that's a nice language feature, and one we should probably use more. Thanks!
There was a problem hiding this comment.
Yeah, I'm in the habit of being very pedantic about that and using it nearly everywhere.
There was a problem hiding this comment.
Improvements like that are always welcome, if you're in the mood to improve our API.
There was a problem hiding this comment.
Nice to know that this is available with c++17. Thought these attributes are for c++20.
6cda3b9 to
9b24fa4
Compare
9b24fa4 to
fcb0a0b
Compare
| @@ -255,7 +255,7 @@ void AddNewEdgeVerts( | |||
| [&](size_t hash) { mutexes[hash % mutexes.size()].unlock(); }, | |||
| std::placeholders::_1); | |||
| tbb::parallel_for( | |||
| tbb::blocked_range<size_t>(0_z, p1q2.size(), 32), | |||
| tbb::blocked_range<size_t>(0_uz, p1q2.size(), 32), | |||
There was a problem hiding this comment.
FWIW, tbb::blocked_range will inver its type, so tbb::blocked_range(0_uz, p1q2.size(), 32), should work just as well.
| tbb::parallel_for( | ||
| tbb::blocked_range<size_t>( | ||
| 0_uz, static_cast<size_t>(std::distance(first, last))), | ||
| [&](const tbb::blocked_range<size_t> &range) { | ||
| std::transform(first + range.begin(), first + range.end(), | ||
| d_first + range.begin(), f); | ||
| }); |
There was a problem hiding this comment.
I believe this can be
tbb::parallel_for(
tbb::blocked_range(first, last),
[&](const auto& range) {
std::transform(range.begin(), range.end(),
d_first + std::distance(first, range.begin()), f);
});
#868
I don't see a
public_test.cppanywhere. Is there somewhere I should put the test for this?