Avoid Wundef trigger #861
Merged
Avoid Wundef trigger #861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files8000@@ Coverage Diff @@
## master #861 +/- ##
==========================================
- Coverage 91.84% 90.04% -1.80%
==========================================
Files 37 65 +28
Lines 4976 9069 +4093
Branches 0 946 +946
==========================================
+ Hits 4570 8166 +3596
- Misses 406 903 +497 ☔ View full report in Codecov by Sentry. |
elalish
approved these changes
Jul 10, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Manifold headers are included in BRL-CAD, one of our compile flags doesn't like MANIFOLD_EXCEPTIONS being undefined - if I'm not mistaken, we can just check for the definition here, without worrying about its specific value.