removed cross_section dependency from manifold #850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pca006132
reviewed
Jun 19, 2024
| return Invalid(); | ||
| Polygons polygons; | ||
| float radius = 0; | ||
| for (const SimplePolygon& poly : crossSection) { |
There was a problem hiding this comment.
It seems that our only non-trivial change is here. Do we have test cases that can cover it? While the logic is simple, it is easy to have bugs here.
There was a problem hiding this comment.
Indeed - yes this originally came in from an external contributor who put in test cases for it, so I think we're covered.
|
I think we can just merge this? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of several steps toward #803, and specifically addressing #664 (comment). Now Manifold has no direct dependence on Clipper2 - Clipper2 is only a dependency of CrossSection (2D), which is independent of Manifold (3D). We rely only the very simple
Polygonsclass as an interface between these libraries, akin toMesh.Since we build our Python and JS bindings with Manifold and CrossSection bundled together, I'm keeping their APIs from changing, so they still accept and return
CrossSectioninstead ofPolygon, since that feels a little nicer.