8000 update clipper2 by pca006132 · Pull Request #817 · elalish/manifold · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

update clipper2 #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 24, 2024
Merged

update clipper2 #817

merged 4 commits into from
May 24, 2024

Conversation

pca006132
Copy link
Collaborator
@pca006132 pca006132 commented May 22, 2024

clipper2 update of #816 for running CIs

Fixes #813, verified by #818.

@pca006132
Copy link
Collaborator Author

for some reason I cannot install clipper2 properly, will have to look into it

I am a bit sick now so will leave for another day

@elalish elalish mentioned this pull request May 22, 2024
Copy link
codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.22%. Comparing base (d437097) to head (68a192c).
Report is 28 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #817      +/-   ##
==========================================
- Coverage   91.84%   89.22%   -2.62%     
==========================================
  Files          37       61      +24     
  Lines        4976     8444    +3468     
  Branches        0      928     +928     
==========================================
+ Hits         4570     7534    +2964     
- Misses        406      910     +504     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner
@elalish elalish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pca006132 pca006132 merged commit d78b1e2 into elalish:master May 24, 2024
18 checks passed
@pca006132 pca006132 deleted the clipper2-update branch May 24, 2024 16:41
@kintel kintel mentioned this pull request Jun 4, 2024
@elalish elalish mentioned this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash in Project()
2 participants
0