Smooth quads #793
Smooth quads #793
Conversation
There was a problem hiding this comment.
@pca006132 The CI is reproducing what I see locally - these smooth/refine tests are now throwing Vec out of range, but when I run each test in isolation, they pass just fine. I tried address sanitizer, and it finds an integer overflow, but a check in that function finds nothing. Any ideas?
| @@ -91,7 +91,7 @@ else() | |||
| else() | |||
| set(WARNING_FLAGS -Werror -Wall -Wno-sign-compare -Wno-unused) | |||
| endif() | |||
| set(MANIFOLD_FLAGS ${MANIFOLD_FLAGS} ${WARNING_FLAGS} -O3) | |||
There was a problem hiding this comment.
Removing this lets release and debug mode work by default - debug mode actually works great now that we're not on CUDA.
There was a problem hiding this comment.
Sounds like something caused by -O3? Perhaps we got some undefined behavior... I should look into this later.
There was a problem hiding this comment.
No, the undefined behavior is independent of the amount of optimization.
There was a problem hiding this comment.
Ah, so removing this line does not make it work, just allows you to compile in debug mode?
There was a problem hiding this comment.
exactly - and actually I just solved the problem. Turns out I had some extra unused verts that weren't being used, but were being processed and contained undefined stuff. Address sanitizer is great, but even though it doesn't slow down running a debug build that much, it makes the actual debugger unusably slow. Oh well, went back to print statements and figured it out.
|
@hrgdavor, since you were interested, smoothing is working better now. From our We can use With refined geometry and flat facets (based either on vertex normals or the geometry directly - same results in this case): With refined geometry and interpolated normals: Now the normals match the geometry better and the shape looks real. |
|
However, our interpolation is not perfectly circular (it still has slight ridges where the original mesh's edges were, though it is at least G1 continuous). It never will be perfect, but I may try to improve it a bit still: Screen.Recording.2024-04-24.at.2.26.45.PM.mov |
|
Cylinders are perfect at least. |
|
@elalish thanks for sharing the visuals. I really admire you work on manifold. I have finally started to play a bit with manifold, so looking forward to trying out these things after I spend some time with basics. |
Adding quad smoothing support, for proper cylinders, etc.