Fixed float overflow #714
Merged
Fixed float overflow #714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test case for #712 - these glb inputs were generated from manifolds that succeeded in producing a Boolean output, but (on one platform but not another) the Status() call on the output boolean manifold crashed. (A test for calling Status() on the output captured on the crashing platform (in case there was something specifically bad about that particular output on that platform) was tried, but the result was simply a successful Status() call even with that specific input - hence, that additional test is not included in this commit.)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #714 +/- ##
=======================================
Coverage 91.67% 91.67%
=======================================
Files 37 37
Lines 4730 4731 +1
=======================================
+ Hits 4336 4337 +1
Misses 394 394 ☔ View full report in Codecov by Sentry. |
cartesian-theatrics
pushed a commit
to cartesian-theatrics/manifold
that referenced
this pull request
Mar 11, 2024
* Set up test for subtraction of a very large cuboid Test case for elalish#712 - these glb inputs were generated from manifolds that succeeded in producing a Boolean output, but (on one platform but not another) the Status() call on the output boolean manifold crashed. (A test for calling Status() on the output captured on the crashing platform (in case there was something specifically bad about that particular output on that platform) was tried, but the result was simply a successful Status() call even with that specific input - hence, that additional test is not included in this commit.) * fixed 0 * inf * switch to ASSERT * tighten test --------- Co-authored-by: Clifford Yapp <238416+starseeker@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #712
It turns out the problem is that
0 * (FLOAT_MAX + FLOAT_MAX) = NaN, but only on certain compilers/architectures. Fixed with an extra check, and did a little cleanup since we aren't using CUDA anymore.