8000 CrossSection::Compose was accidently left out of Python API. by briansturgill · Pull Request #700 · elalish/manifold · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

CrossSection::Compose was accidently left out of Python API. #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2024
Merged

CrossSection::Compose was accidently left out of Python API. #700

merged 1 commit into from
Jan 13, 2024

Conversation

briansturgill
Copy link
Contributor

@pca006132 fixed the nanobind issue, so this works now too!

@codecov Codecov
Copy link
codecov bot commented Jan 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (887a502) 91.67% compared to head (9b9e61b) 91.67%.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #700   +/-   ##
=======================================
  Coverage   91.67%   91.67%           
=======================================
  Files          37       37           
  Lines        4730     4730           
=======================================
  Hits         4336     4336           
  Misses        394      394

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

elalish
elalish approved these changes Jan 13, 2024
View reviewed changes
Copy link
Owner
@elalish elalish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you!

@pca006132 pca006132 merged commit afc64f2 into elalish:master Jan 13, 2024
cartesian-theatrics pushed a commit to cartesian-theatrics/manifold that referenced this pull request Mar 11, 2024
@briansturgill
CrossSection::Compose was accidently left out of Python API. (elalish…
d2848e6 
…#700)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elalish elalish elalish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@briansturgill @elalish @pca006132
0