fix default partial revolve segments #684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #684 +/- ##
==========================================
+ Coverage 91.65% 91.67% +0.01%
==========================================
Files 37 37
Lines 4731 4730 -1
==========================================
Hits 4336 4336
+ Misses 395 394 -1 ☔ View full report in Codecov by Sentry. |
Merged
cartesian-theatrics
pushed a commit
to cartesian-theatrics/manifold
that referenced
this pull request
Mar 11, 2024
* fixed revolve * correct default segments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that with partial revolves, the segments were getting more dense as the angle got smaller. This keeps it more in line with our global concepts of minAngle and minLength.