8000 [python] add revolveDegrees to revolve() API by wrongbad · Pull Request #646 · elalish/manifold · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[python] add revolveDegrees to revolve() API #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2023
Merged

[python] add revolveDegrees to revolve() API #646

merged 1 commit into from
Dec 12, 2023

Conversation

wrongbad
Copy link
Contributor

I tested a simple example locally. I built & installed the python package with this change. Generated a simple manifold by revolving a polygon 220 degrees, and previewed the result did the right thing.

@codecov Codecov
Copy link
codecov bot commented Dec 11, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e15f4cf) 91.58% compared to head (d55da39) 91.58%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #646   +/-   ##
=======================================
  Coverage   91.58%   91.58%           
=======================================
  Files          36       36           
  Lines        4693     4693           
=======================================
  Hits         4298     4298           
  Misses        395      395

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

elalish
elalish approved these changes Dec 12, 2023
View reviewed changes
Copy link
Owner
@elalish elalish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping to keep our bindings up to date!

@elalish elalish merged commit 80edfee into elalish:master Dec 12, 2023
@elalish elalish mentioned this pull request Jan 7, 2024
Merged
cartesian-theatrics pushed a commit to cartesian-theatrics/manifold that referenced this pull request Mar 11, 2024
@wrongbad
[python] add revolveDegrees to revolve() API (elalish#646)
73b66ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elalish elalish elalish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wrongbad @elalish
0