8000 Add animation to manifoldCAD by elalish · Pull Request #624 · elalish/manifold · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add animation to manifoldCAD #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 19, 2023
Merged

Add animation to manifoldCAD #624

merged 6 commits into from
Nov 19, 2023

Conversation

elalish
Copy link
Owner
@elalish elalish commented Nov 19, 2023

This adds node-level animation support to manifoldCAD.org, along with an animation scrubber. This vaguely follows a similar feature in OpenSCAD, but is more powerful, particularly because the CSG tree doesn't need to be re-evaluated per animation frame, and it's exported properly to our GLB files.

I updated our tetrahedron puzzle example to show off the feature:
image

@elalish elalish self-assigned this Nov 19, 2023
Copy link
codecov bot commented Nov 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4551288) 91.41% compared to head (ef0034a) 91.40%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #624      +/-   ##
==========================================
- Coverage   91.41%   91.40%   -0.02%     
==========================================
  Files          35       35              
  Lines        4497     4512      +15     
==========================================
+ Hits         4111     4124      +13     
- Misses        386      388       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hrgdavor
Copy link

that is awesome, gotta try it :)

@elalish
Copy link
Owner Author
elalish commented Nov 19, 2023

Thanks! This PR also gives the ability to change our default material, via globalDefaults, which also controls the animation.

@elalish elalish merged commit e273f6b into master Nov 19, 2023
@elalish elalish deleted the animation branch November 19, 2023 18:49
@elalish elalish mentioned this pull request Jan 7, 2024
cartesian-theatrics pushed a commit to cartesian-theatrics/manifold that referenced this pull request Mar 11, 2024
* added global config

* translation animation works

* single times accessor

* animations working

* animation controls working

* add icons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0