[FEAT] Add Status() to the Python Bindings #558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will help consumers of the Python bindings diagnose why their input meshes are not translating into manifolds properly...
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #558 +/- ##
=======================================
Coverage 91.13% 91.13%
=======================================
Files 35 35
Lines 4547 4547
=======================================
Hits 4144 4144
Misses 403 403 ☔ View full report in Codecov by Sentry. |
|
Note: I recommend turning on MANIFOLD_DEBUG as well, which will have slight performance impact, but it can catch some geometry/topology errors. |
|
Hmm, I'd rather not turn on |
Merged
Merged
cartesian-theatrics
pushed a commit
to cartesian-theatrics/manifold
that referenced
this pull request
Mar 11, 2024
* Add Status() to the Python Bindings This will help consumers of the Python bindings diagnose why their input meshes are not translating into manifolds properly... * Make clang-format happier * Use its suggestions verbatim
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help consumers of the Python bindings diagnose why their input meshes are not translating into manifolds properly.