Add CI check for formatting more languages #441
Conversation
|
This will mean the CI complains, but without configs for the particular formatters we won't be coordinated to keep the checks happy will we? I'm not sure what it is that is being run for my formatting by the lsp, I think it's prettier for js. So I think we'd need a prettier config. |
|
I'm using clang-format for everything, with |
|
Oh, I wasn't aware clang-format did non C/C++ stuff. I'll look into swapping that in. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #441 +/- ##
=======================================
Coverage 89.70% 89.70%
=======================================
Files 35 35
Lines 4237 4237
=======================================
Hits 3801 3801
Misses 436 436 ☔ View full report in Codecov by Sentry. |
|
I've got clang-format running now, but it looks like I'm going to have to wrestle with it a bit. It is splitting |
|
Alright, well I never figured out why running clang-format through the usual formatter setup, but I went around it! Diffs are way down on the JS PR, so it seems like it is working as advertised. |
* add format files * some fixes
Let's see if this works. FYI @geoffder.