8000 Add `--toolbar-space` to offset the margin. by elainajones · Pull Request #8 · elainajones/remarkable-calendar · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add --toolbar-space to offset the margin. #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 7, 2024
Merged

Add --toolbar-space to offset the margin. #8

merged 9 commits into from
Oct 7, 2024

Conversation

elainajones
Copy link
Owner
  • Moves global variables into main()
  • Define variables for all coordinates to remove undefined hard-coding
  • Add left/right hand toolbar space so that the toolbar doesn't overlap
  • Adjust placement of calendar to leave room for page number pop up (this overlapped before)
  • Fix line placement issues which were previously 'eye-balled' using proper math.

@elainajones
refactor: Move global variables into main
0086ca1
@elainajones
refactor: Daily view positions and variables
579f01b 
Refactor daily view with updated coordinates and variables. This
drastically simplifies coordinate hard-coding and uses clearer
naming of variables. Lines are correctly defined to remove overlap
without "eyeballing" to fix poorly defined edges.
@elainajones
refactor: Monthly view positions and variables
f4e9d8d 
Refactor monthly view with updated coordinates and variables. This
drastically simplifies coordinate hard-coding and uses clearer
naming of variables. Lines are correctly defined to remove overlap
without "eyeballing" to fix poorly defined edges.
@elainajones
refactor: Monthly view date placement
d756763 
Refactor monthly view date placement with updated variables. This
drastically simplifies coordinate hard-coding and uses clearer
naming of variables.
@elainajones
fix: Hour interval logic
f7c6ca8 
Fixes hour interval logic with updated variables.
@elainajones
fix: Daily view 3rd line length
1caf021 
Fixes end y coordinate of bold 3rd vertical line from left. This
hung over the end of the grid a tiny amount due to a '+' sign that
should have been '-'.
@elainajones
feat: Add left/right toolbar spacing
d51dcc0 
Adds `--toolbar-space [left|right]` to add space for the toolbar
depending on handedness.
@elainajones
refactor: Deprecate foo.py for POC changes
6fb34c5
@elainajones
fix: Flip toolbar spacing
c48ef03 
Flips toolbar spacing since the toolbar is on the opposite
side of the dominant hand.
@elainajones elainajones merged commit 9d58b3c into main Oct 7, 2024
This was referenced Oct 7, 2024
Closed
Closed
@elainajones elainajones changed the title Develop Add --toolbar-space to offset the margin. Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@elainajones
0