Tags: elamaran619/chromedp
Tags
Fix deadlock in TestPrematureCancel. The `c.allocated` channel is only written in `NewContext`, and subsequently closed when the browser is allocated. But the browser is allocated in `Run` and this test calls `Cancel` before `Run`, so the channel couldn't possible receive any more data nor be closed for a second read to not block.
Fix Browser goroutine/memory leak race Previously, the websocket read could race with context cancellation. The (*Browser).run goroutine would return without signalling the allocator cleanup goroutine to exit, which leaked a goroutine and prevented garbage collecting the Browser memory. Fixes chromedp#552
PreviousNext