8000 Automate beam energy configurations by simonge · Pull Request #886 · eic/epic · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Automate beam energy configurations #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Automate beam energy configurations #886

wants to merge 5 commits into from
+60 −542

Conversation

simonge
Copy link
Contributor
@simonge simonge commented Jun 4, 2025

Briefly, what does this PR introduce?

Aiming to address eic/EICrecon#1899 by automatically adding xml configurations for all beam energy combinations to detector setups which include far_forward or far_backward subsystems.

Also changes the default energy from 18x275 to 5x41 when no values are provided.

Some of the yml files probably don't need the far detector subsystems for the studies they are used for so could be removed.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No

Does this PR change default behavior?

Adds a lot more xml files to confuse the users.

@simonge simonge requested a review from wdconinc June 4, 2025 22:12
@wdconinc
Copy link
Contributor
wdconinc commented Jun 4, 2025

We run some ci for every configuration and I think it may be based on the files in configurations/. Does that still work and does it blow up the CI load?

@github-actions github-actions bot added the topic: infrastructure Regarding build system, CI, CD label Jun 4, 2025
@simonge simonge force-pushed the Automate-beam-energy-configurations branch from 68354d4 to c592377 Compare June 5, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wdconinc wdconinc Awaiting requested review from wdconinc

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
topic: infrastructure Regarding build system, CI, CD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonge @wdconinc
0