linux-eic-shell.yml: fix download step in build-artifacts-page #859
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doesn't look like `artifacts/` were supposed to be used https://github.com/eic/EICrecon/blob/734cd480d8637ac50837db0d70da0ac48a1498d5/.github/workflows/linux-eic-shell.yml#L1161C11-L1162
wdconinc
reviewed
May 6, 2025
| @@ -779,7 +779,8 @@ jobs: | |||
| - name: Download GitHub Pages staging artifact | |||
| uses: actions/download-artifact@v4 | |||
| with: | |||
| path: artifacts/ | |||
There was a problem hiding this comment.
I think this is the wrong direction of this change. See links in README.md (which becomes https://eic.github.io/epic/index.html), and reports/artifacts.md.
I think what we may want to do is keep artifacts, and then publish _site or so.
There was a problem hiding this comment.
And we've been advertising links like https://eic.github.io/epic//artifacts/epic_craterlake_no_bhcal.stp/epic_craterlake_no_bhcal.stp to others, like project and similar gdml files to Makoto Asai. We should try not to have them break.
There was a problem hiding this comment.
Maybe we should just revert #856 and make it work first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help with issues like https://github.com/eic/epic/actions/runs/14817178151/job/41749142343#step:7:7
Doesn't look like
artifacts/were supposed to be used https://github.com/eic/EICrecon/blob/734cd480d8637ac50837db0d70da0ac48a1498d5/.github/workflows/linux-eic-shell.yml#L1161C11-L1162Briefly, what does this PR introduce?
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
Does this PR change default behavior?