Use pixel-style MPDG readout for tracking until efficiency issues are resolved #1819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, |
ybedfer
reviewed
Apr 22, 2025
ybedfer
approved these changes
Apr 22, 2025
|
Can we add this plot as a benchmark? |
Yes, definitely. We discussed the need for this last Thurday. |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin v1.24
git worktree add -d .worktree/backport-1819-to-v1.24 origin/v1.24
cd .worktree/backport-1819-to-v1.24
git switch --create backport-1819-to-v1.24
git cherry-pick -x b2d08908cecb1fb812afc1f240cb1289620f83a6 |
8000
veprbl
pushed a commit
that referenced
this pull request
Apr 22, 2025
… resolved (#1819) As presented in the tracking WG meeting ([https://indico.bnl.gov/event/27589/contributions/105659/attachments/60986/104773/tracking1_040325.pdf](https://indico.bnl.gov/event/27589/contributions/105659/attachments/60986/104773/tracking1_040325.pdf)), the updated 2D MPGD digitization leads to inefficiencies for the Barrel MPGD. This PR restores the previous digitization scheme as the default, where the hits are used in the track reconstruction with high efficiency. Once the 2D readout can demonstrate comparable results, we will switch over. Results with 2D digitization: <img width="647" alt="image1" src="https://github.com/user-attachments/assets/5785ed7a-faa3-44d7-a8ba-b566edde82b8" /> Results with pixel-style (SVT-like) digitization: <img width="653" alt="image2" src="https://github.com/user-attachments/assets/217d8ae4-7d7f-4a65-9b49-ce1b6a5bc4a7" /> - [ ] Bug fix (issue #__) - [ ] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ - [x] Tests for the changes have been added - [ ] Documentation has been added / updated - [x] Changes have been communicated to collaborators @ShujieL @ybedfer need to make to their code? No Yes, it restores previous barrel MPGD digitization scheme as default. (cherry picked from commit b2d0890)
Capybara summary for PR 1819
|
veprbl
pushed a commit
that referenced
this pull request
Apr 22, 2025
… resolved (#1819) As presented in the tracking WG meeting ([https://indico.bnl.gov/event/27589/contributions/105659/attachments/60986/104773/tracking1_040325.pdf](https://indico.bnl.gov/event/27589/contributions/105659/attachments/60986/104773/tracking1_040325.pdf)), the updated 2D MPGD digitization leads to inefficiencies for the Barrel MPGD. This PR restores the previous digitization scheme as the default, where the hits are used in the track reconstruction with high efficiency. Once the 2D readout can demonstrate comparable results, we will switch over. Results with 2D digitization: <img width="647" alt="image1" src="https://github.com/user-attachments/assets/5785ed7a-faa3-44d7-a8ba-b566edde82b8" /> Results with pixel-style (SVT-like) digitization: <img width="653" alt="image2" src="https://github.com/user-attachments/assets/217d8ae4-7d7f-4a65-9b49-ce1b6a5bc4a7" /> - [ ] Bug fix (issue #__) - [ ] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ - [x] Tests for the changes have been added - [ ] Documentation has been added / updated - [x] Changes have been communicated to collaborators @ShujieL @ybedfer need to make to their code? No Yes, it restores previous barrel MPGD digitization scheme as default. (cherry picked from commit b2d0890)
7 tasks
veprbl
added a commit
that referenced
this pull request
Apr 22, 2025
…ciency issues are resolved (#1819) (#1820) As presented in the tracking WG meeting ([https://indico.bnl.gov/event/27589/contributions/105659/attachments/60986/104773/tracking1_040325.pdf](https://indico.bnl.gov/event/27589/contributions/105659/attachments/60986/104773/tracking1_040325.pdf)), the updated 2D MPGD digitization leads to inefficiencies for the Barrel MPGD. This PR restores the previous digitization scheme as the default, where the hits are used in the track reconstruction with high efficiency. Once the 2D readout can demonstrate comparable results, we will switch over. Results with 2D digitization: <img width="647" alt="image1" src="https://github.com/user-attachments/assets/5785ed7a-faa3-44d7-a8ba-b566edde82b8" /> Results with pixel-style (SVT-like) digitization: <img width="653" alt="image2" src="https://github.com/user-attachments/assets/217d8ae4-7d7f-4a65-9b49-ce1b6a5bc4a7" /> - [ ] Bug fix (issue #__) - [ ] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ - [x] Tests for the changes have been added - [ ] Documentation has been added / updated - [x] Changes have been communicated to collaborators @ShujieL @ybedfer need to make to their code? No Yes, it restores previous barrel MPGD digitization scheme as default. (cherry picked from commit b2d0890) Co-authored-by: Barak Schmookler <bschmookler1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
As presented in the tracking WG meeting (https://indico.bnl.gov/event/27589/contributions/105659/attachments/60986/104773/tracking1_040325.pdf), the updated 2D MPGD digitization leads to inefficiencies for the Barrel MPGD.
This PR restores the previous digitization scheme as the default, where the hits are used in the track reconstruction with high efficiency. Once the 2D readout can demonstrate comparable results, we will switch over.
Results with 2D digitization:
Results with pixel-style (SVT-like) digitization:
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No
Does this PR change default behavior?
Yes, it restores previous barrel MPGD digitization scheme as default.