8000 Bump to offheap-store 2.5.5 by mathieucarbou · Pull Request #3200 · ehcache/ehcache3 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bump to offheap-store 2.5.5 #3200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Conversation

mathieucarbou
Copy link
Member

No description provided.

@mathieucarbou mathieucarbou self-assigned this Oct 17, 2023
@@ -70,6 +70,7 @@ public Option[] individualModules() {
gradleBundle("org.terracotta:statistics"),
gradleBundle("org.ehcache:sizeof"),
gradleBundle("org.terracotta:offheap-store"),
gradleBundle("org.terracotta:fast-restartable-store"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm... should the offheap-store manifest declare an optional dependency on fast-restartable-store?

Copy link
Member Author
@mathieucarbou mathieucarbou Oct 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah that was my question when I did that... I don't know. Do we have other cases like that in Echache ?

it could also be a PM question lol ;-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kinda feel like this depends on when/if we move the features FRS supports in to OSS.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we don't know the answer now, what is best to do: mark is optional, and eventually later remove the optional, or mark it required from start, eventually by marking it optional later ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That... but we should open the discussion on the topic.

@chrisdennis chrisdennis self-requested a review October 24, 2023 12:57
@chrisdennis chrisdennis merged commit 3c40c0d into ehcache:master Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0